Skip to content

Conversation

@VerinSenpai
Copy link
Contributor

@VerinSenpai VerinSenpai commented Oct 19, 2025

About the PR

Requires #40966. Note that until that PR is merged, this test will fail.

Superseded by #40977 (No hard feelings 😢)

Why / Balance

See #40966

Technical details

Test first places a mosin in the players hand and fetches the wieldable component from it.
Next it gets the hand count for the player entity. This is done so we can check to ensure the player still only has one hand, otherwise this test is pointless.
Verifies that the mosin was spawned in not wielded.
Interacts with the mosin to wield it and then checks again that it is not wielded.

Requirements

@PJBot PJBot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/S Denotes a PR that changes 10-99 lines. labels Oct 19, 2025
@VerinSenpai VerinSenpai added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content D3: Low Difficulty: Some codebase knowledge required. A: Integration Tests Area: Integration tests, adding or fixing them S: Requires Content PR Status: Requires a change to SS14, for which there is no open PR currently. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Oct 19, 2025
@VerinSenpai
Copy link
Contributor Author

On second thought, I'm gonna take a crack at creating a prototype in the test so I don't have to be dependent on a particular firearm staying wieldable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A: Integration Tests Area: Integration tests, adding or fixing them D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. S: Requires Content PR Status: Requires a change to SS14, for which there is no open PR currently. size/S Denotes a PR that changes 10-99 lines. T: New Feature Type: New feature or content, or extending existing content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants